ChromeOS: Update styles of material design OOBE.

ChromeOS: Update styles of material design OOBE.

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09aaf40bab8fc78fb38634b7cdbdf3f975a1cf6f
Cr-Commit-Position: refs/heads/master@{#414695}

[Alexander Alekseev, 2016-08-20 07:43:56]

Description was changed from

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
==========

to

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2016-08-20 07:44:22]

alemate@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Alexander Alekseev, 2016-08-20 07:44:23]

Please review.

[Alexander Alekseev, 2016-08-20 07:44:30]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 07:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 08:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 08:27:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Alekseev, 2016-08-20 21:39:34]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 21:39:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 22:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 22:14:49]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-23 18:40:29]

can you please upload a screenshot?

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_dialog.html (right):

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog.html:10: It has corect size
and padding. It can display top left icon, and has
"correct"

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:32: <img
id="welcomeIllustration" src="images/welcome_illustration_1x.png">
should this be dependent on screen size?

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:35:
on-tap="onWelcomeNextButtonClicked_"
4-space indents

[Alexander Alekseev, 2016-08-25 00:21:48]

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_dialog.html (right):

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_dialog.html:10: It has corect size
and padding. It can display top left icon, and has
On 2016/08/23 18:40:29, michaelpg wrote:
> "correct"

Done.

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:32: <img
id="welcomeIllustration" src="images/welcome_illustration_1x.png">
On 2016/08/23 18:40:29, michaelpg wrote:
> should this be dependent on screen size?

Yes, but I postponed this for later (as all the other icons should depend on it
too.)

https://codereview.chromium.org/2267533002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.html:35:
on-tap="onWelcomeNextButtonClicked_"
On 2016/08/23 18:40:29, michaelpg wrote:
> 4-space indents

Done.

[michaelpg, 2016-08-26 06:33:44]

a few small fixes needed, otherwise LGTM

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_text_button.css (right):

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_text_button.css:6: font: 13px
Roboto medium, sans-serif;
use quotes for font names containing whitespace: 'Roboto Medium'

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:32: <img
id="welcomeIllustration" src="images/welcome_illustration_1x.png">
id unused?

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:33: </img>
<img> doesn't use closing tags

[Alexander Alekseev, 2016-08-26 10:49:10]

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_text_button.css (right):

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_text_button.css:6: font: 13px
Roboto medium, sans-serif;
On 2016/08/26 06:33:44, michaelpg wrote:
> use quotes for font names containing whitespace: 'Roboto Medium'

Done.

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (right):

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:32: <img
id="welcomeIllustration" src="images/welcome_illustration_1x.png">
On 2016/08/26 06:33:44, michaelpg wrote:
> id unused?

It is referenced on top of the style file:

#welcomeScreen #welcomeIllustration {                                           

  height: max-content;                                                          

  width: max-content;                                                           

}

https://codereview.chromium.org/2267533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:33: </img>
On 2016/08/26 06:33:44, michaelpg wrote:
> <img> doesn't use closing tags

Done.

[Alexander Alekseev, 2016-08-26 10:49:49]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-08-26 10:49:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2267533002/#ps60001
(title: "Update after review")

[commit-bot: I haz the power, 2016-08-26 10:50:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 13:14:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 13:16:31]

Description was changed from

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS: Update styles of material design OOBE.

This CL fixes styles of Welcome screen.

BUG=604119
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/09aaf40bab8fc78fb38634b7cdbdf3f975a1cf6f
Cr-Commit-Position: refs/heads/master@{#414695}
==========

[commit-bot: I haz the power, 2016-08-26 13:16:32]

Patchset 4 (id:??) landed as
https://crrev.com/09aaf40bab8fc78fb38634b7cdbdf3f975a1cf6f
Cr-Commit-Position: refs/heads/master@{#414695}