Disallow 'await' in object literal shorthand position

Disallow 'await' in object literal shorthand position

Also lots of cleanup around the checking for 'await' as an identifier
throughout the parser and preparser.

R=caitp@igalia.com, littledan@chromium.org
BUG=v8:4483, v8:5298
Committed: https://crrev.com/253d4e84646fdd1b9faebbd63adb30f09a5fa4dc
Cr-Commit-Position: refs/heads/master@{#38798}

[adamk, 2016-08-20 00:54:40]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 00:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-20 00:58:02]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 00:58:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-20 01:00:54]

https://codereview.chromium.org/2267493002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2267493002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:1980: parsing_module_ || is_async_function()) &&
To be clear, this is the bugfix, everything else is cleanup that resulted from
noticing the inconsistency around the use of "Identifiers" everywhere else.

[commit-bot: I haz the power, 2016-08-20 02:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 02:19:59]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/12821)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Dan Ehrenberg, 2016-08-22 00:27:50]

On 2016/08/20 at 00:54:36, adamk wrote:
> 

A general comment: when you find missing async function tests like this, it
would be useful to report them to test262, e.g. with a comment on
https://github.com/tc39/test262/issues/740 . This and the other patch you have
out for review are fairly basic properties that other implementations may also
run into.

[Dan Ehrenberg, 2016-08-22 00:40:20]

lgtm

Great cleanups and nice simple fix.

[adamk, 2016-08-22 17:26:38]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-08-22 17:26:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-22 17:26:48]

On 2016/08/22 00:27:50, Dan Ehrenberg wrote:
> On 2016/08/20 at 00:54:36, adamk wrote:
> > 
> 
> A general comment: when you find missing async function tests like this, it
> would be useful to report them to test262, e.g. with a comment on
> https://github.com/tc39/test262/issues/740 . This and the other patch you have
> out for review are fairly basic properties that other implementations may also
> run into.

Will do

[commit-bot: I haz the power, 2016-08-22 18:03:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 18:04:08]

Description was changed from

==========
Disallow 'await' in object literal shorthand position

Also lots of cleanup around the checking for 'await' as an identifier
throughout the parser and preparser.

R=caitp@igalia.com, littledan@chromium.org
BUG=v8:4483,v8:5298
==========

to

==========
Disallow 'await' in object literal shorthand position

Also lots of cleanup around the checking for 'await' as an identifier
throughout the parser and preparser.

R=caitp@igalia.com, littledan@chromium.org
BUG=v8:4483,v8:5298

Committed: https://crrev.com/253d4e84646fdd1b9faebbd63adb30f09a5fa4dc
Cr-Commit-Position: refs/heads/master@{#38798}
==========

[commit-bot: I haz the power, 2016-08-22 18:04:09]

Patchset 2 (id:??) landed as
https://crrev.com/253d4e84646fdd1b9faebbd63adb30f09a5fa4dc
Cr-Commit-Position: refs/heads/master@{#38798}