Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2267483002: Revert of Reland Introduce mojo interface for collecting StackSamplingProfiler data (Closed)

Created:
4 years, 4 months ago by alexmos
Modified:
4 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, asvitkine+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Introduce mojo interface for collecting StackSamplingProfiler data (patchset #3 id:40001 of https://codereview.chromium.org/2253013008/ ) Reason for revert: Appears to break compile on Mac: https://build.chromium.org/p/chromium/builders/Mac/builds/18700/ Error: [10847/43976] LIBTOOL-STATIC obj/components/metrics/libcall_stacks.a FAILED: obj/components/metrics/libcall_stacks.a rm -f obj/components/metrics/libcall_stacks.a && TOOL_VERSION=1468839730 python ../../build/toolchain/mac/filter_libtool.py libtool -static -o obj/components/metrics/libcall_stacks.a error: /Applications/Xcode5.1.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Original issue's description: > Reland Introduce mojo interface for collecting StackSamplingProfiler data > > Adds interfaces, typemaps, and tests for collecting > StackSamplingProfiler result types. The collection interface will be > used to receive stack profiles from non-browser processes. > > This change was previously reverted in > https://codereview.chromium.org/2264613002/ for introducing a skia > dependency that broke cronet. The dependency has been removed and the > new code has been split into independent targets. > > BUG=517958 > > Committed: https://crrev.com/a6e65bb0cea385fc9fa82a5a1af4a5c3616e43e4 > Cr-Commit-Position: refs/heads/master@{#413285} TBR=sky@chromium.org,tsepez@chromium.org,isherman@chromium.org,wittman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517958 Committed: https://crrev.com/0078b95aa4f7d5183924fd9113276e2dde312ca5 Cr-Commit-Position: refs/heads/master@{#413293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -551 lines) Patch
M base/profiler/stack_sampling_profiler.h View 1 chunk +2 lines, -4 lines 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 2 chunks +1 line, -9 lines 0 comments Download
M components/metrics/BUILD.gn View 3 chunks +1 line, -14 lines 0 comments Download
M components/metrics/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/metrics/public/cpp/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/metrics/public/cpp/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/metrics/public/cpp/call_stack_profile.typemap View 1 chunk +0 lines, -17 lines 0 comments Download
D components/metrics/public/cpp/call_stack_profile_struct_traits.h View 1 chunk +0 lines, -138 lines 0 comments Download
D components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc View 1 chunk +0 lines, -251 lines 0 comments Download
D components/metrics/public/cpp/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
D components/metrics/public/interfaces/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D components/metrics/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/metrics/public/interfaces/call_stack_profile_collector.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
D components/metrics/public/interfaces/call_stack_profile_collector_test.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
alexmos
Created Revert of Reland Introduce mojo interface for collecting StackSamplingProfiler data
4 years, 4 months ago (2016-08-20 00:29:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267483002/1
4 years, 4 months ago (2016-08-20 00:30:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:31:27 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:33:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0078b95aa4f7d5183924fd9113276e2dde312ca5
Cr-Commit-Position: refs/heads/master@{#413293}

Powered by Google App Engine
This is Rietveld 408576698