Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2267473002: Revert "Implement parsing support for generic functions" (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Implement parsing support for generic functions" This reverts commit 19af8524710507ff29ec077ce3e1e67e5a7e8f30. Checked tests failed. Will work on this on Monday. TBR=asiva Committed: https://github.com/dart-lang/sdk/commit/a1edb1766fd16b1268f3506feb7c9856b32bedfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -322 lines) Patch
M runtime/vm/parser.h View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 28 chunks +114 lines, -300 lines 0 comments Download
M tests/language/generic_functions_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_function_type_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_new_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_methods_type_expression_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
hausner
Committed patchset #1 (id:1) manually as a1edb1766fd16b1268f3506feb7c9856b32bedfc (presubmit successful).
4 years, 4 months ago (2016-08-19 23:40:12 UTC) #4
hausner
4 years, 4 months ago (2016-08-19 23:40:28 UTC) #5
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698