Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2267443002: [Android] Fix some nits in DownloadItemWrapper (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix some nits in DownloadItemWrapper This CL fixes some nits in DownloadHistoryItemWrapper, including java class attributs initialization, and java unboxing. BUG=NONE Committed: https://crrev.com/7fab9e1e4ba4038a8f2f3f8254d303a8a94f2b28 Cr-Commit-Position: refs/heads/master@{#413301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
This big CL is urgent, complex, and feature critical. Let's merge it to M52. Haha ...
4 years, 4 months ago (2016-08-19 22:54:52 UTC) #2
gone
The realism of the situation hurts. lgtm
4 years, 4 months ago (2016-08-19 23:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267443002/1
4 years, 4 months ago (2016-08-19 23:03:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:52:14 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:55:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fab9e1e4ba4038a8f2f3f8254d303a8a94f2b28
Cr-Commit-Position: refs/heads/master@{#413301}

Powered by Google App Engine
This is Rietveld 408576698