Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2267433002: Run ScreenshotSync tests with both software and GPU rasterization. (Closed)

Created:
4 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
vmiura
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run ScreenshotSync tests with both software and GPU rasterization. They were previously only running in GPU rasterization mode, which is apparently expected to not work on at least some platforms. However, this exposed a bug on Windows with AMD GCN GPUs, which must be investigated and which is being suppressed. BUG=639489 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/dc76813e2aac9bc53fa9bde968e22917c26a30f6 Cr-Commit-Position: refs/heads/master@{#413305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M content/test/gpu/gpu_tests/screenshot_sync.py View 3 chunks +51 lines, -6 lines 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync_expectations.py View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 4 months ago (2016-08-19 22:34:13 UTC) #3
vmiura
LGTM. Thanks for adding this.
4 years, 4 months ago (2016-08-19 22:38:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267433002/1
4 years, 4 months ago (2016-08-19 22:44:20 UTC) #6
Ken Russell (switch to Gerrit)
On 2016/08/19 22:44:20, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 4 months ago (2016-08-20 00:49:45 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-20 01:40:35 UTC) #9
Ken Russell (switch to Gerrit)
The failures on linux_android_rel_ng are unrelated to this patch. CQ'ing NOTRY=true.
4 years, 4 months ago (2016-08-20 01:50:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267433002/1
4 years, 4 months ago (2016-08-20 01:51:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 01:56:26 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 01:57:52 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc76813e2aac9bc53fa9bde968e22917c26a30f6
Cr-Commit-Position: refs/heads/master@{#413305}

Powered by Google App Engine
This is Rietveld 408576698