Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 226743004: Relax the assert in SkReadBuffer::setPictureVersion(). (Closed)

Created:
6 years, 8 months ago by f(malita)
Modified:
6 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Relax the assert in SkReadBuffer::setPictureVersion(). I'm hitting this with SkPictureShader serialization because there can be multiple pictures deserialized from the same buffer. I think we can relax the assert to allow setting the same version multiple times. (Alternatively, we could guard all the callers - but since setting the same version is a no-op, that seems overkill) R=mtklein@google.com, reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=14089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkReadBuffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
f(malita)
6 years, 8 months ago (2014-04-08 13:26:36 UTC) #1
mtklein
On 2014/04/08 13:26:36, Florin Malita wrote: lgtm
6 years, 8 months ago (2014-04-08 14:03:32 UTC) #2
reed1
lgtm
6 years, 8 months ago (2014-04-08 14:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/226743004/1
6 years, 8 months ago (2014-04-08 14:11:22 UTC) #4
f(malita)
6 years, 8 months ago (2014-04-08 14:11:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r14089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698