Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2267423004: [Merge to 2785] Discard correct drawing buffer (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to 2785] Discard correct drawing buffer > This partly revert https://codereview.chromium.org/1950053003. On > platform supported GL_EXT_discard_framebuffer extension, it causes a > WebGL conformance test regression: > conformance/state/state-uneffected-after-compositing.html > > The root cause is current bound fbo will be discarded other than the > default fbo. We should discard default fbo correctly. > > BUG=628472 > > Review-Url: https://codereview.chromium.org/2145093003 > Cr-Commit-Position: refs/heads/master@{#405689} > (cherry picked from commit fd383c4428d3a4e1041425214f001661dca8d173) Committed: https://chromium.googlesource.com/chromium/src/+/87afbee2e2f123fc576d4274a563f2a628189501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
erikchen
Committed patchset #1 (id:1) manually as 87afbee2e2f123fc576d4274a563f2a628189501.
4 years, 4 months ago (2016-08-24 17:16:31 UTC) #2
boliu
err, this was merged without approval, and also not link to the new bug? (google ...
4 years, 3 months ago (2016-08-25 20:10:15 UTC) #4
boliu
4 years, 3 months ago (2016-08-25 20:10:46 UTC) #5
Message was sent while issue was closed.
On 2016/08/25 20:10:15, boliu wrote:
> err, this was merged without approval, and also not link to the new bug?
(google
> private crbug.com/639944)

oh, merge approval on that other bug, meh..

Powered by Google App Engine
This is Rietveld 408576698