Issue 2267423003: Add DCHECKs to check that toV8 never returns an empty handle

Issue 2267423003: Add DCHECKs to check that toV8 never returns an empty handle (Closed)

Created:
4 years, 4 months ago by haraken

Modified:
4 years, 4 months ago

Reviewers:
Yuki

CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add DCHECKs to check that toV8 never returns an empty handle BUG=625512 Committed: https://crrev.com/829be45c2826d816879153c0134307964d402614 Cr-Commit-Position: refs/heads/master@{#414023}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/bindings/core/v8/ToV8.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267423003/1

4 years, 4 months ago (2016-08-24 07:03:06 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-24 08:40:35 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/829be45c2826d816879153c0134307964d402614
Cr-Commit-Position: refs/heads/master@{#414023}