Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: java/org/chromium/distiller/ContentExtractor.java

Issue 2267403008: Fix partially hidden article (Closed) Base URL: git@github.com:chromium/dom-distiller.git@master
Patch Set: speed optimization Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | java/org/chromium/distiller/webdocument/DomConverter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: java/org/chromium/distiller/ContentExtractor.java
diff --git a/java/org/chromium/distiller/ContentExtractor.java b/java/org/chromium/distiller/ContentExtractor.java
index e5858b6e875b972790e0c1d040772e07a2b6c01e..d84a232f56b7f46148ae4d2ec58825b1c497acdf 100644
--- a/java/org/chromium/distiller/ContentExtractor.java
+++ b/java/org/chromium/distiller/ContentExtractor.java
@@ -44,7 +44,7 @@ public class ContentExtractor {
public ContentExtractor(Element root) {
documentElement = root;
- candidateTitles = new LinkedList<String>();
+ candidateTitles = new LinkedList<>();
mTimingInfo = TimingInfo.create();
mStatisticsInfo = StatisticsInfo.create();
@@ -164,9 +164,20 @@ public class ContentExtractor {
private WebDocumentInfo createWebDocumentInfoFromPage() {
WebDocumentInfo info = new WebDocumentInfo();
WebDocumentBuilder documentBuilder = new WebDocumentBuilder();
+
+ NodeList<Element> mobileViewport = DomUtil.querySelectorAll(documentElement,
+ "meta[name=\"viewport\"][content*=\"width=device-width\"]");
DomConverter converter = new DomConverter(documentBuilder);
+ converter.setIsMobileFriendly(mobileViewport.getLength() > 0);
+
Element walkerRoot = DomUtil.getArticleElement(documentElement);
- if (walkerRoot == null) {
+ converter.setHasArticleElement(walkerRoot != null);
+
+ if (walkerRoot != null) {
+ if (LogUtil.isLoggable(LogUtil.DEBUG_LEVEL_BOILER_PIPE_PHASES)) {
+ LogUtil.logToConsole("Extracted article element: " + walkerRoot);
+ }
+ } else {
walkerRoot = documentElement;
}
new DomWalker(converter).walk(walkerRoot);
« no previous file with comments | « no previous file | java/org/chromium/distiller/webdocument/DomConverter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698