third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Iterable.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

index 61679bc0ffeedf9cf7d840eac24cf9b674dac549..d3109d9d1c9daabd7c564daa0074ab7999b6b729 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h

@@ -119,10 +119,7 @@ void ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::reject(PassR

template<typename HolderType, typename ResolvedType, typename RejectedType>

v8::Local<v8::Object> ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::holder(v8::Isolate* isolate, v8::Local<v8::Object> creationContext)

{

- v8::Local<v8::Value> value = toV8(m_holder, creationContext, isolate);

- if (value.IsEmpty())

- return v8::Local<v8::Object>();

- return value.As<v8::Object>();

+ return toV8(m_holder, creationContext, isolate).As<v8::Object>();

}

template<typename HolderType, typename ResolvedType, typename RejectedType>