Issue 22674012: [NaCl SDK] Roll naclports revision.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22674012: [NaCl SDK] Roll naclports revision. (Closed)

Created:
7 years, 4 months ago by Sam Clegg

Modified:
7 years, 4 months ago

Reviewers:
binji

CC:
chromium-reviews, binji

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Roll naclports revision. This change brings in a new version of naclports which is needed to fix the current breakage due to pnacl-translate no longer working on non-finalized executables. The new version of naclports, among other things, will always finalize before translating during build. TEST=build_sdk.py --build-ports R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216792

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	native_client_sdk/src/build_tools/build_sdk.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

Running tryjob now with patch that also enables the naclports build (which trybots normally do ...

7 years, 4 months ago (2013-08-09 23:33:03 UTC) #1

Sam Clegg

7 years, 4 months ago (2013-08-10 00:52:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r216792 (presubmit successful).

Expand Messages | Collapse Messages