third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2267383003: [LayoutNG] Introduces NGPhysicalConstraintSpace and makes NGConstraintSpace a "view".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2267383003: [LayoutNG] Introduces NGPhysicalConstraintSpace and makes NGConstraintSpace a "view". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: .. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_box.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_box.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 9327201da56b3c4af311799f94cb11112ad4f5b3..596d99d0f86f2ef47bb19409559c25211ea073d3 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -25,10 +25,8 @@ TEST_F(NGBlockLayoutAlgorithmTest, FixedSize) {

style_->setWidth(Length(30, Fixed));

style_->setHeight(Length(40, Fixed));

- NGLogicalSize container_size;

- container_size.inline_size = LayoutUnit(100);

- container_size.block_size = NGSizeIndefinite;

- NGConstraintSpace space(container_size);

+ NGConstraintSpace* space = new NGConstraintSpace(

+ HorizontalTopBottom, NGLogicalSize(LayoutUnit(100), NGSizeIndefinite));

NGBlockLayoutAlgorithm algorithm(style_, NGBoxIterator(NGBox()));

NGFragment* frag = algorithm.layout(space);