Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2267373004: Add a comment to caution that timer::stop() should not be called too much (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment to caution that timer::stop() should not be called too much As requested by kinuko-san in https://codereview.chromium.org/2124693002/ BUG= Committed: https://crrev.com/b2d65acc7b0d61ff6c8a4121b9952fb77c16c121 Cr-Commit-Position: refs/heads/master@{#414007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
nhiroki@: PTAL
4 years, 4 months ago (2016-08-24 05:57:19 UTC) #2
nhiroki
lgtm
4 years, 4 months ago (2016-08-24 05:59:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267373004/1
4 years, 4 months ago (2016-08-24 06:00:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 07:38:39 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 07:40:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2d65acc7b0d61ff6c8a4121b9952fb77c16c121
Cr-Commit-Position: refs/heads/master@{#414007}

Powered by Google App Engine
This is Rietveld 408576698