Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2267363007:
Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded (Closed)
|
Created:
4 years, 3 months ago by kojii Modified:
4 years, 3 months ago Reviewers:
eae CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLoop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded
Somehow VS2015 does not apply tail-recursion, and hits stack overflow
even in official build. Crashes were reported on CrOS too.
This patch changes it to loop.
No behavior changes.
BUG=583711, 640869
Committed: https://crrev.com/775f244f3b549c5887adc6d945656f52685d800c
Cr-Commit-Position: refs/heads/master@{#414491}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== whitespece-recursion BUG= ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even for official build or Canary. This patch changes it to loop. BUG=583711 ==========
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even for official build or Canary. This patch changes it to loop. BUG=583711 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. This patch changes it to loop. BUG=583711 ==========
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. This patch changes it to loop. BUG=583711 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. This patch changes it to loop. Crashes were reported on CrOS too. BUG=583711 ==========
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. This patch changes it to loop. Crashes were reported on CrOS too. BUG=583711 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. BUG=583711 ==========
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. BUG=583711 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. BUG=583711, 640869 ==========
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. BUG=583711, 640869 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. No behavior changes. BUG=583711, 640869 ==========
kojii@chromium.org changed reviewers: + eae@chromium.org
PTAL. Only 5+ lines change to enclosed with a loop and replaced recursion with continue, but git doesn't figure it out without "-w" option.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. No behavior changes. BUG=583711, 640869 ========== to ========== Loop instead of tail-recursion in adjustMidpointsAndAppendRunsForObjectIfNeeded Somehow VS2015 does not apply tail-recursion, and hits stack overflow even in official build. Crashes were reported on CrOS too. This patch changes it to loop. No behavior changes. BUG=583711, 640869 Committed: https://crrev.com/775f244f3b549c5887adc6d945656f52685d800c Cr-Commit-Position: refs/heads/master@{#414491} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/775f244f3b549c5887adc6d945656f52685d800c Cr-Commit-Position: refs/heads/master@{#414491} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
