Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2267363005: Convert editing/execCommand/4641880-2.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/execCommand/4641880-2.html to use w3c test harness This patch converts "editing/execCommand/4641880-2.html" to use w3c test harness to simplify test script, and renames to "indent_at_end_of_paragraph.html" to provide hint what this test script verifies, for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/c4ae6c8ad82de6dc6b5f683137963b0dfa77fef0 Cr-Commit-Position: refs/heads/master@{#414308}

Patch Set 1 : 2016-08-24T15:36:34 #

Total comments: 2

Patch Set 2 : 2016-08-24T17:39:32 #

Messages

Total messages: 22 (13 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-24 07:57:52 UTC) #5
Xiaocheng
https://codereview.chromium.org/2267363005/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html File third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html (right): https://codereview.chromium.org/2267363005/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html#newcode9 third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html:9: '^This paragraph should be in a list.<br>|', Please change ...
4 years, 4 months ago (2016-08-24 08:14:48 UTC) #8
yosin_UTC9
PTAL Updated sample and expected texts. https://codereview.chromium.org/2267363005/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html File third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html (right): https://codereview.chromium.org/2267363005/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html#newcode9 third_party/WebKit/LayoutTests/editing/execCommand/indent_at_end_of_paragraph.html:9: '^This paragraph should ...
4 years, 4 months ago (2016-08-24 08:44:07 UTC) #11
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-24 08:48:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267363005/20001
4 years, 4 months ago (2016-08-24 08:54:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/285524)
4 years, 4 months ago (2016-08-24 12:04:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267363005/20001
4 years, 4 months ago (2016-08-25 01:28:13 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 04:19:47 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 04:23:01 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4ae6c8ad82de6dc6b5f683137963b0dfa77fef0
Cr-Commit-Position: refs/heads/master@{#414308}

Powered by Google App Engine
This is Rietveld 408576698