Simplify CRC2D winding rule handling

Simplify CRC2D winding rule handling

Since the bindings already check the enumeration, there's no need to
check that the value passed is valid. Make the parseWinding helper function
just return the translated value instead of a status boolean.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171438

[Justin Novosad, 2014-04-11 17:34:30]

On 2014/04/11 17:04:03, fs wrote:

I imagine we already have layout tests that verify the handling of invalid
strings.  Could you just update the description to specify which tests cover
this?

lgtm

[fs, 2014-04-11 17:58:16]

On 2014/04/11 17:34:30, junov wrote:
> On 2014/04/11 17:04:03, fs wrote:
> 
> I imagine we already have layout tests that verify the handling of invalid
> strings.  Could you just update the description to specify which tests cover
> this?

Actually, no tests seem to (intentionally) test this. I'll add some additional
cases to fast/canvas/canvas-isPointInPath-winding and
fast/canvas/canvas-path-context-{fill,clip}.

[fs, 2014-04-11 18:12:10]

Some tests added, please CQ if it looks ok (or I'll do that Monday.)

[Justin Novosad, 2014-04-11 18:35:36]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:35:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/226733004/20001

[Justin Novosad, 2014-04-11 18:35:42]

On 2014/04/11 18:12:10, fs wrote:
> Some tests added, please CQ if it looks ok (or I'll do that Monday.)

lgtm

[commit-bot: I haz the power, 2014-04-11 18:44:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:44:46]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Justin Novosad, 2014-04-11 20:02:05]

On 2014/04/11 18:44:46, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on linux_blink_rel

Needs new baselines?

[fs, 2014-04-14 07:13:43]

On 2014/04/11 20:02:05, junov wrote:
> On 2014/04/11 18:44:46, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   tryserver.blink on linux_blink_rel
> 
> Needs new baselines?

Yepp. Missed virtual/gpu.

[fs, 2014-04-14 07:50:44]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-14 07:50:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/226733004/40001

[commit-bot: I haz the power, 2014-04-14 08:08:54]

Change committed as 171438