Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2267293003: Make webrtc recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make webrtc recipes explicitly set GIT_MODE This doesn't actually result in any expectation changes (yay!), but doing it anyway to increase confidence in the cleanup later on. R=kjellander@chromium.org, martiniss@chromium.org BUG=640251 Committed: https://chromium.googlesource.com/chromium/tools/build/+/da7d759d2b8a6a43fbbc882bd6e0fb5f6847f4d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/ios.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/ios_api_framework.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
agable
4 years, 4 months ago (2016-08-23 22:42:22 UTC) #1
martiniss
lgtm
4 years, 4 months ago (2016-08-23 22:49:33 UTC) #2
kjellander_chromium
lgtm
4 years, 4 months ago (2016-08-24 14:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267293003/1
4 years, 4 months ago (2016-08-24 16:23:19 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:27:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/da7d759d2b8a6a43fbbc...

Powered by Google App Engine
This is Rietveld 408576698