Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2267283003: CHECK that QuicHttpStream::callback_ is null in any methods which may (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CHECK that QuicHttpStream::callback_ is null in any methods which may set the callback. Should help explain how we're crashing in http://crbug.com/640288 BUG=640288 Committed: https://crrev.com/29c9de5f7c2a8dcf3eb4acff102561a684bb6665 Cr-Commit-Position: refs/heads/master@{#414213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M net/quic/chromium/quic_http_stream.cc View 5 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
4 years, 4 months ago (2016-08-23 22:34:59 UTC) #2
Zhongyi Shi
lgtm. Sorry about the delay.
4 years, 4 months ago (2016-08-24 17:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267283003/1
4 years, 4 months ago (2016-08-24 18:25:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129203)
4 years, 3 months ago (2016-08-24 22:50:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267283003/1
4 years, 3 months ago (2016-08-24 22:52:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 00:17:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:20:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29c9de5f7c2a8dcf3eb4acff102561a684bb6665
Cr-Commit-Position: refs/heads/master@{#414213}

Powered by Google App Engine
This is Rietveld 408576698