Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2267273005: Add strings for ARC's intent picker incognito mode (Closed)

Created:
4 years, 4 months ago by djacobo_
Modified:
4 years, 3 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strings for ARC's intent picker incognito mode Strings to be shown with ARC's intent picker, these will be displayed on a dialog used to warn the user while browsing on incognito mode. BUG=632161 TEST=NA Committed: https://crrev.com/0211bf97535e7fa73de3f8490f2ee8cfdef93d9b Cr-Commit-Position: refs/heads/master@{#414478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Yusuke Sato
lgtm
4 years, 3 months ago (2016-08-25 17:34:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267273005/1
4 years, 3 months ago (2016-08-25 17:37:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:14:46 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:18:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0211bf97535e7fa73de3f8490f2ee8cfdef93d9b
Cr-Commit-Position: refs/heads/master@{#414478}

Powered by Google App Engine
This is Rietveld 408576698