Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2267273004: Use FlushTargetFilter to pre-filter targets before checking their results. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use FlushTargetFilter to pre-filter targets before checking their results. This helps to reduce number of checks, so makes flushing faster. In non-incremental changes it gives 0.32% -> 0.11%. In incremental changes it gives 10% -> 2.6%. We still pass both target and result into the second filter for convenience, e.g. to print them both without need to remember the current target in a local variable. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2e24662c066e7340f2f60e29fc2f795fd65f6bba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 4 chunks +21 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-24 15:52:26 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-24 16:14:47 UTC) #2
scheglov
4 years, 4 months ago (2016-08-24 16:44:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e24662c066e7340f2f60e29fc2f795fd65f6bba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698