chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html - Issue 2267253002: Make the MR dialog issue banner readable by screen readers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html

Issue 2267253002: Make the MR dialog issue banner readable by screen readers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change aria-live value to polite Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html

diff --git a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html

index d1e859d1e23c951054f8b436df2906f9666e9aa0..e66899f95a3f6713526e870d65eae88b55e89dfa 100644

--- a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html

+++ b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html

@@ -12,7 +12,7 @@

<iron-icon icon="media-router:error-outline" id="blocking-icon">

</iron-icon>

</div>

- <div id="title">[[issue.title]]</div>

+ <div id="title" aria-live="polite" tabindex="0">[[issue.title]]</div>

</div>

<paper-button flat id="opt-button" class="button"

« no previous file with comments | « no previous file | no next file » | no next file with comments »