[cleanup] Eliminate Forgive* methods on ExpressionClassifier

[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.

Committed: https://crrev.com/1bf952072f36c12f9d3080100dad09f7b8423423
Cr-Commit-Position: refs/heads/master@{#38839}

[adamk, 2016-08-23 00:28:01]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 00:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-08-23 00:32:02]

Description was changed from

==========
WIP: Eliminate "Forgiveness" in ExpressionClassifier
==========

to

==========
[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.
==========

[adamk, 2016-08-23 00:32:02]

adamk@chromium.org changed reviewers:
+ caitp@igalia.com, gsathya@chromium.org, littledan@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:57:26]

Dry run: This issue passed the CQ dry run.

[nickie, 2016-08-23 08:24:27]

nikolaos@chromium.org changed reviewers:
+ nikolaos@chromium.org

[nickie, 2016-08-23 08:24:27]

LGTM (for all that it's worth), with one suggestion.

https://codereview.chromium.org/2267223002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2267223002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:2385: ExpressionClassifier::LetPatternProduction |
I'd rather change this to:
(ExpressionClassifier::PatternProductions &
~ExpressionClassifier::AssignmentPatternProduction)
for clarity.

[Dan Ehrenberg, 2016-08-23 15:40:05]

lgtm

[gsathya, 2016-08-23 15:53:09]

lgtm

[adamk, 2016-08-23 18:02:32]

https://codereview.chromium.org/2267223002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2267223002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:2385: ExpressionClassifier::LetPatternProduction |
On 2016/08/23 08:24:27, nickie wrote:
> I'd rather change this to:
> (ExpressionClassifier::PatternProductions &
> ~ExpressionClassifier::AssignmentPatternProduction)
> for clarity.

I've moved all the pattern logic down into the IsValidReferenceExpression if
statement, thanks for the suggestion.

[adamk, 2016-08-23 18:02:54]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-08-23 18:02:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org, littledan@chromium.org, gsathya@chromium.org
Link to the patchset: https://codereview.chromium.org/2267223002/#ps40001
(title: "Move Pattern production logic around")

[commit-bot: I haz the power, 2016-08-23 18:02:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 18:27:19]

Description was changed from

==========
[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.
==========

to

==========
[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.
==========

[commit-bot: I haz the power, 2016-08-23 18:27:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 18:27:33]

Description was changed from

==========
[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.
==========

to

==========
[cleanup] Eliminate Forgive* methods on ExpressionClassifier

The only two places where these Forgive methods were called
was in ParseAssignmentExpression just at the time we were
calling Accumulate(). So instead of Forgiving, we can simply
not accumulate the bits that would have been forgiven.

Also slightly restructures the nearby code in
ParseAssignmentExpression, and removes the use of non-const
references in ExpressionClassifier.

Committed: https://crrev.com/1bf952072f36c12f9d3080100dad09f7b8423423
Cr-Commit-Position: refs/heads/master@{#38839}
==========

[commit-bot: I haz the power, 2016-08-23 18:27:34]

Patchset 3 (id:??) landed as
https://crrev.com/1bf952072f36c12f9d3080100dad09f7b8423423
Cr-Commit-Position: refs/heads/master@{#38839}