Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 22672003: Make WebP decoding independent of stream length. (Closed)

Created:
7 years, 4 months ago by djsollen
Modified:
7 years, 4 months ago
Reviewers:
scroggo, vikasa
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make WebP decoding independent of stream length. There's a case in Android, when the SkStream passed to WebP decoder may have incorrect length (stream->getLength()). This is observed, if the App decodes an image (size > 80KB) using: 'ParcelFileDescriptor --> BitmapFactory.decodeStream()'. This CL updates the WebP incremental decoding loop to not rely on stream->getLength(). R=scroggo@google.com, vikasa@google.com Committed: https://code.google.com/p/skia/source/detail?r=10651

Patch Set 1 #

Total comments: 3

Patch Set 2 : style fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/images/SkImageDecoder_libwebp.cpp View 1 1 chunk +10 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
This moves a CL upstream that was originally committed to Android.
7 years, 4 months ago (2013-08-08 12:43:26 UTC) #1
vikasa
lgtm
7 years, 4 months ago (2013-08-08 16:57:29 UTC) #2
scroggo
lgtm besides some style guide violations. https://codereview.chromium.org/22672003/diff/1/src/images/SkImageDecoder_libwebp.cpp File src/images/SkImageDecoder_libwebp.cpp (right): https://codereview.chromium.org/22672003/diff/1/src/images/SkImageDecoder_libwebp.cpp#newcode209 src/images/SkImageDecoder_libwebp.cpp:209: const uint32_t bytes_to_read ...
7 years, 4 months ago (2013-08-08 18:44:24 UTC) #3
djsollen
Committed patchset #2 manually as r10651 (presubmit successful).
7 years, 4 months ago (2013-08-09 12:33:35 UTC) #4
djsollen
7 years, 4 months ago (2013-08-09 15:19:02 UTC) #5
Message was sent while issue was closed.
On 2013/08/09 12:33:35, djsollen wrote:
> Committed patchset #2 manually as r10651 (presubmit successful).

This change had to be reverted due to failures on Windows.  All the other
platforms built and ran successfully.

http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/bui...

We've filed a bug (https://code.google.com/p/skia/issues/detail?id=1495) to
track the issue.

Powered by Google App Engine
This is Rietveld 408576698