Removing CPDF_Parser::CloseParser.

Removing CPDF_Parser::CloseParser.

Currently the only calls to CloseParser() happend in the destructor or the
start*Parse methods. The Start*Parse methods are currently only called on
freshly constructed parsers in fpdf_dataavail and fpdfview.

This CL removes the CloseParser() method and puts the contents in the
destructor. We then add an ASSERT that we don't re-enter the parser after it
has already completed the parse.

Committed: https://pdfium.googlesource.com/pdfium/+/156de02596e91490bf2432686d0d3c91a5c1a26e

[dsinclair, 2016-08-24 18:46:14]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 18:46:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-24 18:47:32]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-08-24 18:47:32]

PTAL.

[Tom Sepez, 2016-08-24 18:56:00]

lgtm

[dsinclair, 2016-08-24 18:57:49]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-08-24 18:57:49]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 18:58:26]

Description was changed from

==========
Removing CPDF_Parser::CloseParser.

Currently the only calls to CloseParser() happend in the destructor or the
start*Parse methods. The Start*Parse methods are currently only called on
freshly constructed parsers in fpdf_dataavail and fpdfview.

This CL removes the CloseParser() method and puts the contents in the
destructor. We then add an ASSERT that we don't re-enter the parser after it
has already completed the parse.
==========

to

==========
Removing CPDF_Parser::CloseParser.

Currently the only calls to CloseParser() happend in the destructor or the
start*Parse methods. The Start*Parse methods are currently only called on
freshly constructed parsers in fpdf_dataavail and fpdfview.

This CL removes the CloseParser() method and puts the contents in the
destructor. We then add an ASSERT that we don't re-enter the parser after it
has already completed the parse.

Committed:
https://pdfium.googlesource.com/pdfium/+/156de02596e91490bf2432686d0d3c91a5c1...
==========

[commit-bot: I haz the power, 2016-08-24 18:58:27]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/156de02596e91490bf2432686d0d3c91a5c1...