Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2267173003: Remove deprecated UrlRequestContextConfig & HttpUrlRequestFactoryConfig (Closed)

Created:
4 years, 4 months ago by kapishnikov
Modified:
4 years, 3 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated UrlRequestContextConfig & HttpUrlRequestFactoryConfig Committed: https://crrev.com/f892e2844c88b1a62fc1c46a33188d639124b1b4 Cr-Commit-Position: refs/heads/master@{#415657}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Pass null instead of getContext() #

Total comments: 2

Patch Set 3 : Rebase + addressed commnents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -77 lines) Patch
M components/cronet/android/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/api/build.xml View 1 chunk +0 lines, -1 line 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlRequestFactoryConfig.java View 1 chunk +0 lines, -21 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/UrlRequestContextConfig.java View 1 chunk +0 lines, -19 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java View 1 2 8 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
kapishnikov
4 years, 4 months ago (2016-08-23 19:55:49 UTC) #1
mef
https://codereview.chromium.org/2267173003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java File components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java (right): https://codereview.chromium.org/2267173003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java#newcode42 components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java:42: CronetEngine.Builder builder = new CronetEngine.Builder(getContext()); Could you change this ...
4 years, 4 months ago (2016-08-23 20:06:19 UTC) #3
kapishnikov
On 2016/08/23 20:06:19, mef wrote: > https://codereview.chromium.org/2267173003/diff/1/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java > File > components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java > (right): > > ...
4 years, 4 months ago (2016-08-23 21:07:51 UTC) #4
mef
lgtm It maybe worth waiting for consumer changes to land first. https://codereview.chromium.org/2267173003/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java File components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java (right): ...
4 years, 4 months ago (2016-08-23 21:37:50 UTC) #5
kapishnikov
https://codereview.chromium.org/2267173003/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java File components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java (right): https://codereview.chromium.org/2267173003/diff/20001/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java#newcode167 components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java:167: CronetEngine.Builder builder = new CronetEngine.Builder(getContext()); On 2016/08/23 21:37:50, mef ...
4 years, 4 months ago (2016-08-23 22:09:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267173003/20001
4 years, 3 months ago (2016-08-31 14:27:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267173003/40001
4 years, 3 months ago (2016-08-31 14:35:36 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 16:45:15 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:46:32 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f892e2844c88b1a62fc1c46a33188d639124b1b4
Cr-Commit-Position: refs/heads/master@{#415657}

Powered by Google App Engine
This is Rietveld 408576698