Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2267153002: Add a bit of test coverage for callers of destructuring assignment (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
caitp, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a bit of test coverage for callers of destructuring assignment In particular, this covers one caller of CheckDestructuringElement that didn't have tests before. R=caitp@igalia.com Committed: https://crrev.com/ad07b49d7b47b40a2d6f74d04d1b76ceae2a0253 Cr-Commit-Position: refs/heads/master@{#38841}

Patch Set 1 #

Patch Set 2 : More tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
adamk
4 years, 4 months ago (2016-08-22 22:36:23 UTC) #1
adamk
4 years, 4 months ago (2016-08-23 18:58:04 UTC) #4
Dan Ehrenberg
lgtm
4 years, 4 months ago (2016-08-23 19:07:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267153002/20001
4 years, 4 months ago (2016-08-23 19:09:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 19:30:36 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 19:30:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad07b49d7b47b40a2d6f74d04d1b76ceae2a0253
Cr-Commit-Position: refs/heads/master@{#38841}

Powered by Google App Engine
This is Rietveld 408576698