Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2267133002: [MD settings] make About menu item blue when selected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index dd66609cf9564896c5e422e4788bccdc9ef29f9f..29d51ad9a343ed87858f227cd18ef48af1765f1c 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -9,9 +9,11 @@
Polymer({
is: 'settings-menu',
+ behaviors: [settings.RouteObserverBehavior],
+
properties: {
/** @private */
- advancedOpened_: Boolean,
Dan Beam 2016/10/14 00:09:09 this is still referenced from the HTML, but no lon
+ aboutSelected_: Boolean,
/**
* Dictionary defining page visibility.
@@ -43,6 +45,28 @@ Polymer({
},
/**
+ * @param {!settings.Route} newRoute
+ */
+ currentRouteChanged: function(newRoute) {
+ // Make the three menus mutually exclusive.
+ if (settings.Route.ABOUT.contains(newRoute)) {
+ this.aboutSelected_ = true;
+ this.$.advancedMenu.selected = null;
+ this.$.basicMenu.selected = null;
+ } else if (settings.Route.ADVANCED.contains(newRoute)) {
+ this.aboutSelected_ = false;
+ // For routes from URL entry, we need to set selected.
+ this.$.advancedMenu.selected = newRoute.path;
+ this.$.basicMenu.selected = null;
+ } else if (settings.Route.BASIC.contains(newRoute)) {
+ this.aboutSelected_ = false;
+ this.$.advancedMenu.selected = null;
+ // For routes from URL entry, we need to set selected.
+ this.$.basicMenu.selected = newRoute.path;
+ }
+ },
+
+ /**
* @param {!Event} event
* @private
*/
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698