Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2267133002:
[MD settings] make About menu item blue when selected (Closed)
|
Created:
4 years, 4 months ago by dschuyler Modified:
4 years, 2 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] make About menu item blue when selected
This CL corrects a regression on the blue highlighting in the side nav
menu.
BUG=593989, 629783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f
Cr-Commit-Position: refs/heads/master@{#413645}
Patch Set 1 #
Total comments: 5
Patch Set 2 : review changes #
Total comments: 1
Messages
Total messages: 20 (12 generated)
Description was changed from ========== [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG=593989, 629783 ========== to ========== [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG=593989, 629783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
Thanks for the router tips.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm nits only https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_menu/settings_menu.js:19: advancedOpened_: Boolean, I think you can axe this property declaration, since it's not used by any of the method bodies below. https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_menu/settings_menu.js:52: * selections. nit: clarify comment to something like: Update menus based on new route. Or just remove comment.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_menu/settings_menu.js:19: advancedOpened_: Boolean, On 2016/08/22 23:23:00, tommycli wrote: > I think you can axe this property declaration, since it's not used by any of the > method bodies below. Done. https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_menu/settings_menu.js:52: * selections. On 2016/08/22 23:23:00, tommycli wrote: > nit: clarify comment to something like: > > Update menus based on new route. > > Or just remove comment. I wanted to point out that some of the code is important for URLs entered in in the omnibox. I removed the top comment and added more specific comments.
https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_menu/settings_menu.js (right): https://codereview.chromium.org/2267133002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_menu/settings_menu.js:52: * selections. On 2016/08/22 23:35:09, dschuyler wrote: > On 2016/08/22 23:23:00, tommycli wrote: > > nit: clarify comment to something like: > > > > Update menus based on new route. > > > > Or just remove comment. > > I wanted to point out that some of the code > is important for URLs entered in in the omnibox. > I removed the top comment and added more specific > comments. Thanks. New comments helpful. This is a subtle piece
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2267133002/#ps20001 (title: "review changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG=593989, 629783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG=593989, 629783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f Cr-Commit-Position: refs/heads/master@{#413645} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f Cr-Commit-Position: refs/heads/master@{#413645}
Message was sent while issue was closed.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2267133002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_menu/settings_menu.js (left): https://codereview.chromium.org/2267133002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_menu/settings_menu.js:14: advancedOpened_: Boolean, this is still referenced from the HTML, but no longer exists... :( |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
