Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 22671003: Revert 216860 "Add option to import from bookmarks html file to ..." (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 216860 "Add option to import from bookmarks html file to ..." > Add option to import from bookmarks html file to "Import Bookmarks..." dialog. > > To test this new feature one can do the following: > > On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this > by three ways, one is to navigate to chrome://settings/importData, another is > to open chrome://settings (either through wrench menu or navigating to it through > omnibox) and then under the Users category click on "Import Bookmarks..." button > to open the dialog. The third way to open this dialog > is Wrench->Bookmarks->Import Bookmarks and Settings...". > > Once the dialog is opened, open the "From" combobox and select "Bookmarks HTML File" item. > That should uncheck and disable all the checkboxes but "Favorites/Bookmarks" and present a > "Choose file" button in the place where "Import" button was. Click on that new button and select > your bookmarks html file, once you do that the import process should start, and if you file is > ok, chrome should import and present you with a success message. > > BUG=80685 > R=dbeam@chromium.org, isherman@chromium.org > > Review URL: https://codereview.chromium.org/22332003 It broke some Linux Tests of first run: FirstRunMasterPrefsImportBookmarksFile.ImportBookmarksFile: [4452:4452:0810/092454:2260755831:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context. Error: Connection refused ../../chrome/browser/first_run/first_run_browsertest.cc:186: Failure Value of: auto_import_state Actual: 5 Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED | first_run::AUTO_IMPORT_BOOKMARKS_FILE_IMPORTED) Which is: 7 FirstRunMasterPrefsImportDefault.ImportDefault: [4405:4405:0810/092452:2258318309:ERROR:audio_manager_pulse.cc(234)] Failed to connect to the context. Error: Connection refused ../../chrome/browser/first_run/first_run_browsertest.cc:166: Failure Value of: auto_import_state Actual: 1 Expected: MaskExpectedImportState(first_run::AUTO_IMPORT_CALLED | first_run::AUTO_IMPORT_PROFILE_IMPORTED) Which is: 3 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -93 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/importer/importer_list.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/resources/options/import_data_overlay.html View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/resources/options/import_data_overlay.js View 3 chunks +0 lines, -9 lines 0 comments Download
MM trunk/src/chrome/browser/ui/webui/options/import_data_handler.h View 5 chunks +2 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/import_data_handler.cc View 5 chunks +2 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
7 years, 4 months ago (2013-08-10 17:05:08 UTC) #1
tfarina
Committed patchset #1 manually as r216878.
7 years, 4 months ago (2013-08-10 17:06:11 UTC) #2
tfarina
7 years, 4 months ago (2013-08-10 17:07:04 UTC) #3
Message was sent while issue was closed.
Dammit! It broke some first run tests, I couldn't reproduce locally though!

Powered by Google App Engine
This is Rietveld 408576698