Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 22671002: Move i18n collator code to runtime. (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, dcarney
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -451 lines) Patch
D src/extensions/i18n/collator.h View 1 chunk +0 lines, -68 lines 0 comments Download
D src/extensions/i18n/collator.cc View 1 chunk +0 lines, -366 lines 0 comments Download
M src/extensions/i18n/collator.js View 3 chunks +4 lines, -7 lines 0 comments Download
M src/extensions/i18n/i18n-extension.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/i18n.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/i18n.cc View 4 chunks +284 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime.cc View 2 chunks +74 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-08 07:50:14 UTC) #1
jochen (gone - plz use gerrit)
plz review
7 years, 4 months ago (2013-08-08 08:43:53 UTC) #2
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-09 07:48:56 UTC) #3
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-09 09:51:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698