src/heap.cc - Issue 22670004: Fix/unify root handling in code generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 22670004: Fix/unify root handling in code generation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index d61d0d7a22848f008274ff0b95bbfe48511d2544..9d8a6fad9954d96eb3576d25a90630a29277d794 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -3263,6 +3263,12 @@ bool Heap::RootCanBeWrittenAfterInitialization(Heap::RootListIndex root_index) {

}

+bool Heap::RootCanBeTreatedAsConstant(RootListIndex root_index) {

+ return !RootCanBeWrittenAfterInitialization(root_index) &&

+ !InNewSpace(roots_array_start()[root_index]);

Object* RegExpResultsCache::Lookup(Heap* heap,

String* key_string,

Object* key_pattern,