Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/heap.h

Issue 22670004: Fix/unify root handling in code generation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1597 matching lines...) Expand 10 before | Expand all | Expand 10 after
1608 1608
1609 STATIC_CHECK(kUndefinedValueRootIndex == Internals::kUndefinedValueRootIndex); 1609 STATIC_CHECK(kUndefinedValueRootIndex == Internals::kUndefinedValueRootIndex);
1610 STATIC_CHECK(kNullValueRootIndex == Internals::kNullValueRootIndex); 1610 STATIC_CHECK(kNullValueRootIndex == Internals::kNullValueRootIndex);
1611 STATIC_CHECK(kTrueValueRootIndex == Internals::kTrueValueRootIndex); 1611 STATIC_CHECK(kTrueValueRootIndex == Internals::kTrueValueRootIndex);
1612 STATIC_CHECK(kFalseValueRootIndex == Internals::kFalseValueRootIndex); 1612 STATIC_CHECK(kFalseValueRootIndex == Internals::kFalseValueRootIndex);
1613 STATIC_CHECK(kempty_stringRootIndex == Internals::kEmptyStringRootIndex); 1613 STATIC_CHECK(kempty_stringRootIndex == Internals::kEmptyStringRootIndex);
1614 1614
1615 // Generated code can embed direct references to non-writable roots if 1615 // Generated code can embed direct references to non-writable roots if
1616 // they are in new space. 1616 // they are in new space.
1617 static bool RootCanBeWrittenAfterInitialization(RootListIndex root_index); 1617 static bool RootCanBeWrittenAfterInitialization(RootListIndex root_index);
1618 // Generated code can treat direct references to this root as constant.
1619 bool RootCanBeTreatedAsConstant(RootListIndex root_index);
1618 1620
1619 MUST_USE_RESULT MaybeObject* NumberToString( 1621 MUST_USE_RESULT MaybeObject* NumberToString(
1620 Object* number, bool check_number_string_cache = true, 1622 Object* number, bool check_number_string_cache = true,
1621 PretenureFlag pretenure = NOT_TENURED); 1623 PretenureFlag pretenure = NOT_TENURED);
1622 MUST_USE_RESULT MaybeObject* Uint32ToString( 1624 MUST_USE_RESULT MaybeObject* Uint32ToString(
1623 uint32_t value, bool check_number_string_cache = true); 1625 uint32_t value, bool check_number_string_cache = true);
1624 1626
1625 Map* MapForExternalArrayType(ExternalArrayType array_type); 1627 Map* MapForExternalArrayType(ExternalArrayType array_type);
1626 RootListIndex RootIndexForExternalArrayType( 1628 RootListIndex RootIndexForExternalArrayType(
1627 ExternalArrayType array_type); 1629 ExternalArrayType array_type);
(...skipping 1410 matching lines...) Expand 10 before | Expand all | Expand 10 after
3038 DisallowHeapAllocation no_allocation; // i.e. no gc allowed. 3040 DisallowHeapAllocation no_allocation; // i.e. no gc allowed.
3039 3041
3040 private: 3042 private:
3041 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer); 3043 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
3042 }; 3044 };
3043 #endif // DEBUG 3045 #endif // DEBUG
3044 3046
3045 } } // namespace v8::internal 3047 } } // namespace v8::internal
3046 3048
3047 #endif // V8_HEAP_H_ 3049 #endif // V8_HEAP_H_
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/heap.cc » ('j') | src/ia32/macro-assembler-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698