Issue 2266973002: Allocate script scopes using a separate constructor

Issue 2266973002: Allocate script scopes using a separate constructor (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 4 months ago

Reviewers:
marja

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Allocate script scopes using a separate constructor This avoids checking for outer_scope == nullptr in Scope::Scope BUG=v8:5209 Committed: https://crrev.com/22cb3cba1819f55477090e65d1df93c1f1f4589a Cr-Commit-Position: refs/heads/master@{#38812}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -16 lines)			Patch
M	src/ast/scopes.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/ast/scopes.cc	View	1	4 chunks	+25 lines, -11 lines	0 comments	Download
M	src/parsing/parser-base.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266973002/40001

4 years, 4 months ago (2016-08-23 09:43:10 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-23 10:09:47 UTC) #10

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/22cb3cba1819f55477090e65d1df93c1f1f4589a
Cr-Commit-Position: refs/heads/master@{#38812}