Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 2266913002: DevTools Disable cache should properly handle LoadOnlyFromCache resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 8e4b279b3fa0fdc786943babf6627663822abd35..5105488d1075419512ef874a4c21adde757db359 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -491,8 +491,9 @@ Resource* ResourceFetcher::requestResource(
context().populateRequestData(request.mutableResourceRequest());
if (request.resourceRequest().httpHeaderField("Upgrade-Insecure-Requests") !=
- AtomicString("1"))
+ AtomicString("1")) {
context().modifyRequestForCSP(request.mutableResourceRequest());
+ }
context().addClientHintsIfNecessary(request);
context().addCSPHeaderIfNecessary(factory.type(), request);
@@ -502,6 +503,12 @@ Resource* ResourceFetcher::requestResource(
if (!request.url().isValid())
return nullptr;
+ unsigned long identifier = createUniqueIdentifier();
+ request.mutableResourceRequest().setPriority(computeLoadPriority(
+ factory.type(), request, ResourcePriority::NotVisible));
+ initializeResourceRequest(request.mutableResourceRequest(), factory.type(),
+ request.defer());
+
if (!context().canRequest(
factory.type(), request.resourceRequest(),
MemoryCache::removeFragmentIdentifierIfNeeded(request.url()),
@@ -511,11 +518,6 @@ Resource* ResourceFetcher::requestResource(
return resourceForBlockedRequest(request, factory);
}
- unsigned long identifier = createUniqueIdentifier();
- request.mutableResourceRequest().setPriority(computeLoadPriority(
- factory.type(), request, ResourcePriority::NotVisible));
- initializeResourceRequest(request.mutableResourceRequest(), factory.type(),
- request.defer());
context().willStartLoadingResource(
identifier, request.mutableResourceRequest(), factory.type());
if (!request.url().isValid())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698