Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2266893002: [turbofan] Disable inlining of Cpp builtins in need of argument adaption (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable inlining of Cpp builtins in need of argument adaption Disable inlining of Cpp to a direct CEntryStub call when a call would require argument adaption, i.e. when argument adaption is enabled for the given function and the actual argument count differs from the formal parameter count. This is intended to be a temporary fix until we either disable argument adaption for all Cpp builtins or add adaption logic to inlined Cpp builtins. BUG=chromium:639752 Committed: https://crrev.com/be23ef541b7f48e81f7106e8522a510fb0f441b6 Cr-Commit-Position: refs/heads/master@{#38788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jgruber
4 years, 4 months ago (2016-08-22 13:02:29 UTC) #4
Jarin
lgtm. Thanks! FYI, if you say BUG=chromium:639752 instead of BUG=639752, you will get automatic update ...
4 years, 4 months ago (2016-08-22 14:27:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266893002/1
4 years, 4 months ago (2016-08-22 14:46:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 14:55:18 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:55:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be23ef541b7f48e81f7106e8522a510fb0f441b6
Cr-Commit-Position: refs/heads/master@{#38788}

Powered by Google App Engine
This is Rietveld 408576698