Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3041)

Unified Diff: blimp/client/app/linux/blimp_display_manager.h

Issue 2266863003: blimp: Move BlimpCompositor to use delegated rendering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make gn happy Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/app/compositor/browser_compositor.cc ('k') | blimp/client/app/linux/blimp_display_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/linux/blimp_display_manager.h
diff --git a/blimp/client/app/linux/blimp_display_manager.h b/blimp/client/app/linux/blimp_display_manager.h
index bb123b784c7bbba18a282fccfce0b09ebb9300bc..b379f6f24fddbf04c3cf5bcee08a5512569a8c67 100644
--- a/blimp/client/app/linux/blimp_display_manager.h
+++ b/blimp/client/app/linux/blimp_display_manager.h
@@ -8,7 +8,6 @@
#include <memory>
#include "base/macros.h"
-#include "blimp/client/feature/compositor/blimp_compositor_manager.h"
#include "ui/platform_window/platform_window_delegate.h"
namespace gfx {
@@ -23,6 +22,7 @@ namespace blimp {
namespace client {
class BlimpCompositorManager;
+class BrowserCompositor;
class RenderWidgetFeature;
class TabControlFeature;
@@ -31,8 +31,7 @@ class BlimpDisplayManagerDelegate {
virtual void OnClosed() = 0;
};
-class BlimpDisplayManager : public ui::PlatformWindowDelegate,
- BlimpCompositorManagerClient {
+class BlimpDisplayManager : public ui::PlatformWindowDelegate {
public:
BlimpDisplayManager(const gfx::Size& window_size,
BlimpDisplayManagerDelegate* delegate,
@@ -42,27 +41,25 @@ class BlimpDisplayManager : public ui::PlatformWindowDelegate,
// ui::PlatformWindowDelegate:
void OnBoundsChanged(const gfx::Rect& new_bounds) override;
- void OnDamageRect(const gfx::Rect& damaged_region) override;
+ void OnDamageRect(const gfx::Rect& damaged_region) override {}
void DispatchEvent(ui::Event* event) override;
void OnCloseRequest() override;
void OnClosed() override;
- void OnWindowStateChanged(ui::PlatformWindowState new_state) override;
- void OnLostCapture() override;
+ void OnWindowStateChanged(ui::PlatformWindowState new_state) override {}
+ void OnLostCapture() override {}
void OnAcceleratedWidgetAvailable(gfx::AcceleratedWidget widget,
float device_pixel_ratio) override;
void OnAcceleratedWidgetDestroyed() override;
- void OnActivationChanged(bool active) override;
+ void OnActivationChanged(bool active) override {}
private:
- // BlimpCompositorManagerClient implementation.
- void OnSwapBuffersCompleted() override;
- void DidCommitAndDrawFrame() override;
-
float device_pixel_ratio_;
BlimpDisplayManagerDelegate* delegate_;
TabControlFeature* tab_control_feature_;
+ std::unique_ptr<BrowserCompositor> compositor_;
+
std::unique_ptr<BlimpCompositorManager> blimp_compositor_manager_;
std::unique_ptr<ui::PlatformWindow> platform_window_;
« no previous file with comments | « blimp/client/app/compositor/browser_compositor.cc ('k') | blimp/client/app/linux/blimp_display_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698