Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2747)

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java

Issue 2266863003: blimp: Move BlimpCompositor to use delegated rendering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make gn happy Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/app/android/blimp_view.cc ('k') | blimp/client/app/compositor/browser_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
index acf2ad4019e329a31163d76914b8ca7cd900ee93..b694d38de2af2c5e356505d1bda598dad3f5171d 100644
--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
@@ -13,6 +13,7 @@ import android.view.MotionEvent;
import android.view.Surface;
import android.view.SurfaceHolder;
import android.view.SurfaceView;
+import android.view.View;
import android.view.WindowManager;
import org.chromium.base.annotations.CalledByNative;
@@ -25,7 +26,8 @@ import org.chromium.ui.UiUtils;
* a native compositor.
*/
@JNINamespace("blimp::client")
-public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
+public class BlimpView
+ extends SurfaceView implements SurfaceHolder.Callback, View.OnLayoutChangeListener {
private long mNativeBlimpViewPtr;
/**
@@ -37,6 +39,7 @@ public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
super(context, attrs);
setFocusable(true);
setFocusableInTouchMode(true);
+ addOnLayoutChangeListener(this);
}
/**
@@ -76,21 +79,13 @@ public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
}
}
- /**
- * Triggers a redraw of the native compositor, pushing a new frame.
- */
- public void setNeedsComposite() {
- if (mNativeBlimpViewPtr == 0) return;
- nativeSetNeedsComposite(mNativeBlimpViewPtr);
- }
-
- /**
- * Toggles whether or not the native compositor draws to this {@link View} or not.
- * @param visible Whether or not the compositor should draw or not.
- */
- public void setCompositorVisibility(boolean visible) {
+ // View.OnLayoutChangeListener implementation.
+ @Override
+ public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft,
+ int oldTop, int oldRight, int oldBottom) {
if (mNativeBlimpViewPtr == 0) return;
- nativeSetVisibility(mNativeBlimpViewPtr, visible);
+ nativeOnContentAreaSizeChanged(mNativeBlimpViewPtr, right - left, bottom - top,
+ getContext().getResources().getDisplayMetrics().density);
}
// View overrides.
@@ -191,12 +186,12 @@ public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
private native long nativeInit(BlimpClientSession blimpClientSession, int physicalWidth,
int physicalHeight, int displayWidth, int displayHeight, float dpToPixel);
private native void nativeDestroy(long nativeBlimpView);
- private native void nativeSetNeedsComposite(long nativeBlimpView);
+ private native void nativeOnContentAreaSizeChanged(
+ long nativeBlimpView, int width, int height, float dpToPx);
private native void nativeOnSurfaceChanged(
long nativeBlimpView, int format, int width, int height, Surface surface);
private native void nativeOnSurfaceCreated(long nativeBlimpView);
private native void nativeOnSurfaceDestroyed(long nativeBlimpView);
- private native void nativeSetVisibility(long nativeBlimpView, boolean visible);
private native boolean nativeOnTouchEvent(
long nativeBlimpView, MotionEvent event,
long timeMs, int action, int pointerCount, int historySize, int actionIndex,
« no previous file with comments | « blimp/client/app/android/blimp_view.cc ('k') | blimp/client/app/compositor/browser_compositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698