Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: blimp/BUILD.gn

Issue 2266863003: blimp: Move BlimpCompositor to use delegated rendering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make gn happy Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/client/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/BUILD.gn
diff --git a/blimp/BUILD.gn b/blimp/BUILD.gn
index 7654f2dda74e3dd3eb0f8e99243d880afa6990c5..397ed58d3090a75aae58f1a757b32acef3172089 100644
--- a/blimp/BUILD.gn
+++ b/blimp/BUILD.gn
@@ -6,6 +6,11 @@ import("//build/config/chrome_build.gni")
import("//build/config/ui.gni")
import("//testing/test.gni")
+if (is_android) {
+ import("//build/config/android/config.gni")
+ import("//build/config/android/rules.gni")
+}
+
# Convenience meta-target for all of Blimp's production & test code.
group("blimp") {
# In spite of the name, this really just means that non-test targets
@@ -73,6 +78,35 @@ test("blimp_unittests") {
if (is_linux) {
deps += [ "//blimp/engine:unit_tests" ]
}
+
+ if (is_android) {
+ deps += [ ":blimp_unittests_java_deps" ]
+ }
+}
+
+if (is_android) {
+ # This is the list of targets that the tests need to depend on in order to add
+ # the java classes for their native counterparts to the test apk.
+ # We could directly include them in the test target, but in order to
+ # keep the visibility of the //blimp/client/core:core_java target restricted,
+ # we make it visible to this group (which is testonly) and depend on this
+ # group instead.
+ # We could not add ":blimp_unittests" to the visibility list of
+ # //blimp/client/core:core_java, since the targets that actually need to
+ # depend on it are generated by the test template (see testing/test.gni). So
+ # it was better to add this indirection and expose it to this testonly target,
+ # which can be used in this file only.
+ java_group("blimp_unittests_java_deps") {
+ testonly = true
+ visibility = [ ":*" ]
+
+ deps = [
+ "//base:base_java",
+ "//blimp/client/core:core_java",
+ "//net/android:net_java",
+ "//ui/android:ui_java",
+ ]
+ }
}
if (is_linux) {
« no previous file with comments | « no previous file | blimp/client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698