Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2266843002: Drop is_eval_scope when checking how to access dynamic globals. It has no influence (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/arm64/full-codegen-arm64.cc
diff --git a/src/full-codegen/arm64/full-codegen-arm64.cc b/src/full-codegen/arm64/full-codegen-arm64.cc
index 7f77cdee32ed7e810853c573b00021261ab2782a..1b0f8626bf8022b926b5d99d6a3b654ee7123a42 100644
--- a/src/full-codegen/arm64/full-codegen-arm64.cc
+++ b/src/full-codegen/arm64/full-codegen-arm64.cc
@@ -1187,27 +1187,10 @@ void FullCodeGenerator::EmitLoadGlobalCheckExtensions(VariableProxy* proxy,
}
// If no outer scope calls eval, we do not need to check more
// context extensions.
- if (!s->outer_scope_calls_sloppy_eval() || s->is_eval_scope()) break;
+ if (!s->outer_scope_calls_sloppy_eval()) break;
s = s->outer_scope();
}
- if (s->is_eval_scope()) {
- Label loop, fast;
- __ Mov(next, current);
-
- __ Bind(&loop);
- // Terminate at native context.
- __ Ldr(temp, FieldMemOperand(next, HeapObject::kMapOffset));
- __ JumpIfRoot(temp, Heap::kNativeContextMapRootIndex, &fast);
- // Check that extension is "the hole".
- __ Ldr(temp, ContextMemOperand(next, Context::EXTENSION_INDEX));
- __ JumpIfNotRoot(temp, Heap::kTheHoleValueRootIndex, slow);
- // Load next context in chain.
- __ Ldr(next, ContextMemOperand(next, Context::PREVIOUS_INDEX));
- __ B(&loop);
- __ Bind(&fast);
- }
-
// All extension objects were empty and it is safe to use a normal global
// load machinery.
EmitGlobalVariableLoad(proxy, typeof_mode);
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698