Issue 2266843002: Drop is_eval_scope when checking how to access dynamic globals. It has no influence

Issue 2266843002: Drop is_eval_scope when checking how to access dynamic globals. It has no influence (Closed)

Created:
4 years, 4 months ago by Toon Verwaest

Modified:
4 years, 1 month ago

Reviewers:
neis, Michael Starzinger

CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Drop is_eval_scope when checking how to access dynamic globals. It has no influence BUG= Committed: https://crrev.com/3db269f98c7c085d573fcd2dcb8447242291f31b Cr-Commit-Position: refs/heads/master@{#38773}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -197 lines)			Patch
M	src/compiler/ast-graph-builder.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/full-codegen/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	src/full-codegen/arm64/full-codegen-arm64.cc	View	1 chunk	+1 line, -18 lines	0 comments	Download
M	src/full-codegen/ia32/full-codegen-ia32.cc	View	1 chunk	+2 lines, -24 lines	0 comments	Download
M	src/full-codegen/mips/full-codegen-mips.cc	View	1 chunk	+1 line, -20 lines	0 comments	Download
M	src/full-codegen/mips64/full-codegen-mips64.cc	View	1 chunk	+1 line, -20 lines	0 comments	Download
M	src/full-codegen/ppc/full-codegen-ppc.cc	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	src/full-codegen/s390/full-codegen-s390.cc	View	1 chunk	+1 line, -20 lines	0 comments	Download
M	src/full-codegen/x64/full-codegen-x64.cc	View	1 chunk	+2 lines, -25 lines	0 comments	Download
M	src/full-codegen/x87/full-codegen-x87.cc	View	1 chunk	+1 line, -22 lines	0 comments	Download

Total messages: 13 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266843002/1

4 years, 4 months ago (2016-08-22 09:43:49 UTC) #9

commit-bot: I haz the power

4 years, 4 months ago (2016-08-22 09:46:02 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3db269f98c7c085d573fcd2dcb8447242291f31b
Cr-Commit-Position: refs/heads/master@{#38773}