Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2266813003: Update webkit status for failing test (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update webkit status for failing test Committed: https://crrev.com/e77802f6b087a017e5e0fc04b2ae716131b4b6b2 Cr-Commit-Position: refs/heads/master@{#38780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/webkit/webkit.status View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmcilroy
Failed after addition of extra stack frame on each ast node visit. PTAL.
4 years, 4 months ago (2016-08-22 11:14:24 UTC) #2
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-22 11:19:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266813003/1
4 years, 4 months ago (2016-08-22 11:23:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 11:57:20 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 11:57:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e77802f6b087a017e5e0fc04b2ae716131b4b6b2
Cr-Commit-Position: refs/heads/master@{#38780}

Powered by Google App Engine
This is Rietveld 408576698