Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2266763004: Supply a color space in sRGB/F16 mode of SampleApp (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Supply a color space in sRGB/F16 mode of SampleApp Ganesh now uses this to decide if it should perform gamma-correct rendering, so the color space is necessary to get correct results in S32/F16. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2266763004 Committed: https://skia.googlesource.com/skia/+/7fd64e7e67dfb74a10ab1b9c7cce2cc568d37fd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/views/SkWindow.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Brian Osman
I know SampleApp is on the way out, but I went to use it and ...
4 years, 4 months ago (2016-08-22 15:02:18 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-22 15:17:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266763004/1
4 years, 4 months ago (2016-08-22 15:19:14 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 15:23:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7fd64e7e67dfb74a10ab1b9c7cce2cc568d37fd2

Powered by Google App Engine
This is Rietveld 408576698