Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2266703002: Eliminate race condition when setting model early on TimelineView

Created:
4 years, 4 months ago by nduca
Modified:
4 years, 4 months ago
Reviewers:
nduca
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Eliminate race condition when setting model early on TimelineView When calling TimelineView.model setter before its dom is ready, we would break because model setup assumes readiness. This patch just defers the set call until the ready call. As part of this CL, I eliminate useless copies of children elements stored on the instance, and split out the ready function into created and ready components based on their need of DOM or not. TBR=nduca BUG=catapult:#2252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -34 lines) Patch
M tracing/tracing/ui/timeline_view.html View 9 chunks +45 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266703002/1
4 years, 4 months ago (2016-08-20 02:09:34 UTC) #2
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 02:57:20 UTC) #4
Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

Powered by Google App Engine
This is Rietveld 408576698