Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2266673002: [Extensions] Remove mechanism for non-generated schemas (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove mechanism for non-generated schemas As of https://codereview.chromium.org/2265663002/, all schemas should be generated. Remove the mechanism for "unloaded" (ungenerated) schemas. BUG=638758 Committed: https://crrev.com/6498ddf9b7e71307fc49f6760f20e3a4a1f60c65 Cr-Commit-Position: refs/heads/master@{#413633}

Patch Set 1 #

Patch Set 2 : testfix #

Total comments: 3

Patch Set 3 : lazyboys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -68 lines) Patch
M chrome/common/extensions/api/common_extension_api_unittest.cc View 1 2 4 chunks +23 lines, -8 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/extension_api.h View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M extensions/common/extension_api.cc View 1 2 7 chunks +14 lines, -33 lines 0 comments Download
M extensions/common/extensions_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/test/test_extensions_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/test/test_extensions_client.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Devlin
https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h File extensions/common/extension_api.h (right): https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h#newcode143 extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_; I don't love this, but I also ...
4 years, 4 months ago (2016-08-22 18:30:46 UTC) #8
lazyboy
https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h File extensions/common/extension_api.h (right): https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h#newcode143 extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_; On 2016/08/22 18:30:45, Devlin wrote: > I ...
4 years, 4 months ago (2016-08-22 22:51:31 UTC) #11
Devlin
https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h File extensions/common/extension_api.h (right): https://codereview.chromium.org/2266673002/diff/10001/extensions/common/extension_api.h#newcode143 extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_; On 2016/08/22 22:51:31, lazyboy wrote: > On ...
4 years, 4 months ago (2016-08-23 00:13:08 UTC) #13
lazyboy
lgtm.
4 years, 4 months ago (2016-08-23 00:15:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266673002/30001
4 years, 4 months ago (2016-08-23 02:06:45 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 4 months ago (2016-08-23 02:11:14 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:12:45 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6498ddf9b7e71307fc49f6760f20e3a4a1f60c65
Cr-Commit-Position: refs/heads/master@{#413633}

Powered by Google App Engine
This is Rietveld 408576698