[Extensions] Remove mechanism for non-generated schemas

[Extensions] Remove mechanism for non-generated schemas

As of https://codereview.chromium.org/2265663002/, all schemas should be
generated. Remove the mechanism for "unloaded" (ungenerated) schemas.

BUG=638758
Committed: https://crrev.com/6498ddf9b7e71307fc49f6760f20e3a4a1f60c65
Cr-Commit-Position: refs/heads/master@{#413633}

[Devlin, 2016-08-20 01:17:46]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 01:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 01:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 01:59:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Devlin, 2016-08-22 17:02:57]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 17:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-22 18:30:45]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-08-22 18:30:46]

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
File extensions/common/extension_api.h (right):

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_;
I don't love this, but I also don't have a better idea that doesn't involve a
bunch of churn.  Open to suggestions. :)

[commit-bot: I haz the power, 2016-08-22 20:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:06:02]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2016-08-22 22:51:31]

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
File extensions/common/extension_api.h (right):

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_;
On 2016/08/22 18:30:45, Devlin wrote:
> I don't love this, but I also don't have a better idea that doesn't involve a
> bunch of churn.  Open to suggestions. :)

I would put them in TestExtensionAPI (extending from ExtensionAPI) and use
instance of that class in unit test.

Then RegisterFakeSchemaForTesting method can go in that class.
We only ever need to read fake_schemas_ in
ExtensionAPI::GetAPINameFromFullName(),
so we can extract the "is known/valid api name" check into a virtual function,
e.g.
virtual bool ExtensionAPI::IsKnownAPI(const std::string& api_name) {
  return schemas_.find(api_name) != end ||
ExtensionsClient::Get()->IsAPISchemaGenerated(..);
}
bool TestExtensionAPI::IsKnownAPI(..string& name) override {
  return fake_schemas_.find != end;
}

Of course you'd need a test only class (more work), but keeps fake_schemas_ from
spreading out within the actual ExtensionAPI class.
WDYT?

[Devlin, 2016-08-23 00:12:58]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-08-23 00:13:08]

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
File extensions/common/extension_api.h (right):

https://codereview.chromium.org/2266673002/diff/10001/extensions/common/exten...
extensions/common/extension_api.h:143: std::set<std::string> fake_schemas_;
On 2016/08/22 22:51:31, lazyboy wrote:
> On 2016/08/22 18:30:45, Devlin wrote:
> > I don't love this, but I also don't have a better idea that doesn't involve
a
> > bunch of churn.  Open to suggestions. :)
> 
> I would put them in TestExtensionAPI (extending from ExtensionAPI) and use
> instance of that class in unit test.
> 
> Then RegisterFakeSchemaForTesting method can go in that class.
> We only ever need to read fake_schemas_ in
> ExtensionAPI::GetAPINameFromFullName(),
> so we can extract the "is known/valid api name" check into a virtual function,
> e.g.
> virtual bool ExtensionAPI::IsKnownAPI(const std::string& api_name) {
>   return schemas_.find(api_name) != end ||
> ExtensionsClient::Get()->IsAPISchemaGenerated(..);
> }
> bool TestExtensionAPI::IsKnownAPI(..string& name) override {
>   return fake_schemas_.find != end;
> }
> 
> Of course you'd need a test only class (more work), but keeps fake_schemas_
from
> spreading out within the actual ExtensionAPI class.
> WDYT?

Works for me.  Still not my favorite, but I think this is probably one of those
"the perfect is the enemy of the good" type times.

Thanks for the idea :)

[commit-bot: I haz the power, 2016-08-23 00:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2016-08-23 00:15:56]

lgtm.

[commit-bot: I haz the power, 2016-08-23 01:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 01:49:56]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-23 02:06:00]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-08-23 02:06:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 02:11:14]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-08-23 02:12:44]

Description was changed from

==========
[Extensions] Remove mechanism for non-generated schemas

As of https://codereview.chromium.org/2265663002/, all schemas should be
generated. Remove the mechanism for "unloaded" (ungenerated) schemas.

BUG=638758
==========

to

==========
[Extensions] Remove mechanism for non-generated schemas

As of https://codereview.chromium.org/2265663002/, all schemas should be
generated. Remove the mechanism for "unloaded" (ungenerated) schemas.

BUG=638758

Committed: https://crrev.com/6498ddf9b7e71307fc49f6760f20e3a4a1f60c65
Cr-Commit-Position: refs/heads/master@{#413633}
==========

[commit-bot: I haz the power, 2016-08-23 02:12:45]

Patchset 3 (id:??) landed as
https://crrev.com/6498ddf9b7e71307fc49f6760f20e3a4a1f60c65
Cr-Commit-Position: refs/heads/master@{#413633}