Previews infobar tests

content/public/browser/navigation_handle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 
 #include <memory>
 
+#include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/navigation_throttle.h"
 #include "content/public/common/referrer.h"
 #include "net/base/net_errors.h"
 #include "ui/base/page_transition_types.h"
 
 class GURL;
 
 namespace net {
 class HttpResponseHeaders;
@@ skipping 177 matching lines @@
 
   // Simulates the network request being redirected.
   virtual NavigationThrottle::ThrottleCheckResult
   CallWillRedirectRequestForTesting(const GURL& new_url,
                                     bool new_method_is_post,
                                     const GURL& new_referrer_url,
                                     bool new_is_external_protocol) = 0;
 
   // Simulates the reception of the network response.
   virtual NavigationThrottle::ThrottleCheckResult
-  CallWillProcessResponseForTesting(RenderFrameHost* render_frame_host) = 0;
+  CallWillProcessResponseForTesting(
+      RenderFrameHost* render_frame_host,
+      scoped_refptr<net::HttpResponseHeaders> response_headers) = 0;
+
+  // Simulates the navigation being committed.
+  virtual void CallDidCommitNavigationForTesting(
+      const GURL& url,
+      ui::PageTransition transition,
+      bool same_page,

[clamy, 2016/09/08 13:11:07]

I only see one instance of CallDidCommitNavigationForTesting being used in this
patch, in which |same_page| is set to false. If this is indeed the case, can we
remove this parameter?

[megjablon, 2016/09/08 18:15:25]

Removed.

+      RenderFrameHost* render_frame_host) = 0;

[clamy, 2016/09/08 13:11:07]

It would seem less error prone to not have a RFH there, in particular in light
of this patch https://codereview.chromium.org/2321543002/ since the one that
commits the navigation is supposed to be the one that is inside the
NavigationHandle.

[megjablon, 2016/09/08 18:15:25]

Good call. Done.

 
   // The NavigationData that the embedder returned from
   // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
   // be a clone of the NavigationData.
   virtual NavigationData* GetNavigationData() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_