Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2266633002: [Android] Add user actions for bookmark manager creation (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, asvitkine+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add user actions for bookmark manager creation When checking the recent data about bookmark opening stats, we found a mystery that is hard to explain: the number of bookmark open is larger than the number of bookmark manager open on phones. This CL adds some extra loggings to the bookmark code to seek definite answer to this mystery. BUG=639512 Committed: https://crrev.com/c1d960f82e7bb779979e5cd4b3f8c3bae9b3b6c7 Cr-Commit-Position: refs/heads/master@{#413456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 4 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Ian Wen
PTAL.
4 years, 4 months ago (2016-08-19 23:46:20 UTC) #2
rkaplow
lgtm
4 years, 4 months ago (2016-08-22 15:58:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266633002/1
4 years, 4 months ago (2016-08-22 16:04:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 16:45:29 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:48:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1d960f82e7bb779979e5cd4b3f8c3bae9b3b6c7
Cr-Commit-Position: refs/heads/master@{#413456}

Powered by Google App Engine
This is Rietveld 408576698