chrome/browser/extensions/script_executor.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/script_executor.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no about:blank for user scripts, remove permission from test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/script_executor.cc

diff --git a/chrome/browser/extensions/script_executor.cc b/chrome/browser/extensions/script_executor.cc

index 703a35bd8b7f9aff390b2306780b2359f8ab96b0..7926de9415c27770f7a33ed698c450434087661b 100644

--- a/chrome/browser/extensions/script_executor.cc

+++ b/chrome/browser/extensions/script_executor.cc

@@ -113,6 +113,7 @@ void ScriptExecutor::ExecuteScript(

ScriptExecutor::ScriptType script_type,

const std::string& code,

ScriptExecutor::FrameScope frame_scope,

+ ScriptExecutor::MatchAboutBlank match_about_blank,

UserScript::RunLocation run_at,

ScriptExecutor::WorldType world_type,

ScriptExecutor::ProcessType process_type,

@@ -126,6 +127,7 @@ void ScriptExecutor::ExecuteScript(

params.is_javascript = (script_type == JAVASCRIPT);

params.code = code;

params.all_frames = (frame_scope == ALL_FRAMES);

+ params.match_about_blank = (match_about_blank == MATCH_ABOUT_BLANK);

params.run_at = static_cast<int>(run_at);

params.in_main_world = (world_type == MAIN_WORLD);

params.is_web_view = (process_type == WEB_VIEW_PROCESS);