Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/extensions/user_script_master.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address reviewer's comments (matches->match) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/user_script_master.cc
diff --git a/chrome/browser/extensions/user_script_master.cc b/chrome/browser/extensions/user_script_master.cc
index 03afaa5ca7ed5c2665aaeccab30af74c6d46b58e..9cb40eebcb3b920192b0c05dc9fc89edd6409a7a 100644
--- a/chrome/browser/extensions/user_script_master.cc
+++ b/chrome/browser/extensions/user_script_master.cc
@@ -102,10 +102,14 @@ bool UserScriptMaster::ScriptReloader::ParseMetadataHeader(
std::string value;
if (GetDeclarationValue(line, kIncludeDeclaration, &value)) {
- // We escape some characters that MatchPattern() considers special.
- ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
- ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
- script->add_glob(value);
+ if (value == "about:blank") {
+ script->set_match_about_blank(true);
not at google - send to devlin 2014/04/21 22:34:41 to answer your question: it might be easy, but it'
robwu 2014/04/21 23:21:46 Done.
+ } else {
+ // We escape some characters that MatchPattern() considers special.
+ ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
+ ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
+ script->add_glob(value);
+ }
} else if (GetDeclarationValue(line, kExcludeDeclaration, &value)) {
ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");

Powered by Google App Engine
This is Rietveld 408576698