chrome/browser/extensions/content_script_apitest.cc - Issue 226663003: Allow content script insertion on about:-URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/content_script_apitest.cc

Issue 226663003: Allow content script insertion on about:-URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address reviewer's comments (matches->match) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/content_script_apitest.cc

diff --git a/chrome/browser/extensions/content_script_apitest.cc b/chrome/browser/extensions/content_script_apitest.cc

index b86889e06b733c6cef9156ff81ff1c854fdca006..829d59a42fddd797cff591a50f6e4fe56e6a4fb4 100644

--- a/chrome/browser/extensions/content_script_apitest.cc

+++ b/chrome/browser/extensions/content_script_apitest.cc

@@ -84,6 +84,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContentScriptAboutBlankIframes) {

RunExtensionTest("content_scripts/about_blank_iframes")) << message_;

}

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContentScriptAboutBlankAndSrcdoc) {

+ ASSERT_TRUE(StartEmbeddedTestServer());

+ ASSERT_TRUE(RunExtensionTest("content_scripts/about_blank_srcdoc"))

+ << message_;

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContentScriptExtensionIframe) {

ASSERT_TRUE(StartEmbeddedTestServer());

ASSERT_TRUE(RunExtensionTest("content_scripts/extension_iframe")) << message_;